-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Fix report and personal detail options are persisted after switching account #39753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix report and personal detail options are persisted after switching account #39753
Conversation
|
@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid20.22.mp4Android: mWeb Chromechrome20.22.mp4iOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-05.at.20.08.2820.11.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-05.at.20.10.5420.11.mp4MacOS: Chrome / SafariScreen.Recording.2024-04-05.at.19.41.0319.42.mp4MacOS: DesktopScreen.Recording.2024-04-05.at.20.03.4420.05.mp4 |
paultsimura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
|
@bernhardoj could you please merge |
|
Rerunning perf tests |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…e-is-persisted-after-log-out Fix report and personal detail options are persisted after switching account (cherry picked from commit 4e11f41)
…ging-39753-1 🍒 Cherry pick PR #39753 to staging 🍒
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.60-13 🚀
|
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.60-13 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀
|
Details
We have a context provider to cache the report and personal detail options which is put in App.tsx component. Signing out won't clear the cache, so this PR moves it to the AuthScreen.
Fixed Issues
$ #39710
PROPOSAL: #39710 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-06.at.01.17.07.mov
Android: mWeb Chrome
Screen.Recording.2024-04-06.at.01.15.50.mov
iOS: Native
Screen.Recording.2024-04-06.at.01.11.42.mov
iOS: mWeb Safari
Screen.Recording.2024-04-06.at.01.09.17.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-06.at.01.00.03.mov
MacOS: Desktop
Screen.Recording.2024-04-06.at.01.02.17.mov